Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove old configurations #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cortinico merged 1 commit into from
Aug 9, 2022
Merged

Remove old configurations #5198

cortinico merged 1 commit into from
Aug 9, 2022

Conversation

@BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Aug 7, 2022

I'm opening this as a PR but because it's easier than an Issue in this case.

I think that no one uses this configuration any more. It had sense when all/nearly all the rules didn't have type-solving. But right now configurations like that one have little sense.

If you use these configurations or you think it is worth to keep them just close this PR :)

@github-actions github-actions bot added the build label Aug 7, 2022
@schalkms
Copy link
Member

schalkms commented Aug 8, 2022

Is the file statistics.yaml still referenced somewhere in the code base? I know that a dogfooding approach was used to run detekt's statistic features on the detekt code base. I'm not sure whether we want to keep it.

I think the Gradle config could be removed quite safely.

@BraisGabin
Copy link
Member Author

BraisGabin commented Aug 8, 2022

Is the file statistics.yaml still referenced somewhere in the code base? I know that a dogfooding approach was used to run detekt's statistic features on the detekt code base. I'm not sure whether we want to keep it.

I couldn't find any reference to statistics.yml (except the one that I removed).

@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Aug 8, 2022
@cortinico cortinico added this to the 1.22.0 milestone Aug 9, 2022
@cortinico cortinico merged commit 9d00062 into main Aug 9, 2022
@cortinico cortinico deleted the remove-all-config branch August 9, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3flex 3flex 3flex approved these changes

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

build housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Milestone

1.22.0

Development

Successfully merging this pull request may close these issues.

5 participants

@BraisGabin @schalkms @3flex @cortinico