Implement AlsoCouldBeApply Rule #5333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
approved these changes
Sep 22, 2022
Member
BraisGabin
left a comment
There was a problem hiding this comment.
Thanks to implement this rule! 5 years since it was proposed 😄. LGTM.
Member
|
I think the rule name should be a little more specific, like |
TWiStErRob
reviewed
Sep 24, 2022
detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/MisusedAlsoSpec.kt
Outdated
Show resolved
Hide resolved
...kt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/StyleGuideProvider.kt
Outdated
Show resolved
Hide resolved
detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/MisusedAlso.kt
Outdated
Show resolved
Hide resolved
detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/MisusedAlso.kt
Show resolved
Hide resolved
TWiStErRob
reviewed
Sep 24, 2022
detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/MisusedAlsoSpec.kt
Outdated
Show resolved
Hide resolved
TWiStErRob
reviewed
Sep 24, 2022
detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/MisusedAlsoSpec.kt
Outdated
Show resolved
Hide resolved
TWiStErRob
approved these changes
Sep 27, 2022
Member
TWiStErRob
left a comment
There was a problem hiding this comment.
I'm good, except pending conversations, @BraisGabin can you please look again?
TWiStErRob
reviewed
Sep 28, 2022
...-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/AlsoCouldBeApplySpec.kt
Show resolved
Hide resolved
detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/MisusedAlso.kt
Outdated
Show resolved
Hide resolved
TWiStErRob
reviewed
Sep 28, 2022
Member
TWiStErRob
left a comment
There was a problem hiding this comment.
I had a dream about this, left 3 more comments :)
detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/AlsoCouldBeApply.kt
Outdated
Show resolved
Hide resolved
…is focused on `also` keyword
BraisGabin
approved these changes
Oct 3, 2022
Member
BraisGabin
left a comment
There was a problem hiding this comment.
I re-reviewed the PR and it looks great. Thanks for the reviews @TWiStErRob and the changes @Tommyten.
cortinico
approved these changes
Oct 3, 2022
Member
cortinico
left a comment
There was a problem hiding this comment.
Great stuff! Just a minor nit
detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/AlsoCouldBeApply.kt
Outdated
Show resolved
Hide resolved
cortinico
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest adds a rule to detect
alsoblocks, which could be simplified by using anapplyblock, as discussed in #518.Closes #518