Fix issues introduced by #5152 #5508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the issue with configuration cache originally reported in detekt#5150, while keeping the v1.21 method of determining the classpath for the generated detekt tasks.
BraisGabin
approved these changes
Nov 5, 2022
schalkms
approved these changes
Nov 5, 2022
Member
|
I just tested it. It defenetly fixes all those issues so merging. I couldnt test if it doesn't introduce the other one. |
Contributor
|
Looks like this fixes the issues with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect this
While remaining compatible with the configuration cache (i.e. doesn't reintroduce #5150).
Recommend this get merged, release RC3 and request the reporters of the issues above to retest.