Thanks to visit codestin.com
Credit goes to github.com

Skip to content

NonBooleanPropertyPrefixedWithIs: Allow AtomicBoolean #5577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BraisGabin merged 1 commit into from
Nov 28, 2022
Merged

NonBooleanPropertyPrefixedWithIs: Allow AtomicBoolean #5577

BraisGabin merged 1 commit into from
Nov 28, 2022

Conversation

@t-kameyama
Copy link
Contributor

@t-kameyama t-kameyama commented Nov 28, 2022

Fixes #5553

@github-actions github-actions bot added the rules label Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022 •
edited
Loading

Codecov Report

Merging #5577 (6a13ebb) into main (7fd9987) will increase coverage by 85.88%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##             main    #5577       +/-   ##
===========================================
+ Coverage        0   85.88%   +85.88%     
- Complexity      0     3625     +3625     
===========================================
  Files           0      515      +515     
  Lines           0    12137    +12137     
  Branches        0     2166     +2166     
===========================================
+ Hits            0    10424    +10424     
- Misses          0      627      +627     
- Partials        0     1086     +1086
Impacted Files Coverage Ξ”
...t/rules/naming/NonBooleanPropertyPrefixedWithIs.kt 90.00% <80.00%> (ΓΈ)
...bosch/detekt/rules/naming/BooleanPropertyNaming.kt 94.28% <0.00%> (ΓΈ)
...bosch/detekt/rules/bugs/UnnecessaryNotNullCheck.kt 88.46% <0.00%> (ΓΈ)
...rbosch/detekt/rules/performance/CouldBeSequence.kt 87.50% <0.00%> (ΓΈ)
...h/detekt/formatting/wrappers/SpacingAroundColon.kt 100.00% <0.00%> (ΓΈ)
...ch/detekt/core/reporting/console/FindingsReport.kt 100.00% <0.00%> (ΓΈ)
...h/detekt/rules/naming/InvalidPackageDeclaration.kt 96.77% <0.00%> (ΓΈ)
...lab/arturbosch/detekt/rules/style/MaxLineLength.kt 93.75% <0.00%> (ΓΈ)
...lab/arturbosch/detekt/rules/style/ClassOrdering.kt 84.61% <0.00%> (ΓΈ)
...otlin/io/github/detekt/metrics/ComplexityMetric.kt 100.00% <0.00%> (ΓΈ)
... and 506 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@3flex
Copy link
Member

3flex commented Nov 28, 2022

@t-kameyama thank you for yet another excellent contribution!

cortinico
cortinico approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff

@cortinico cortinico added this to the 1.23.0 milestone Nov 28, 2022
@BraisGabin BraisGabin merged commit 0dd9b87 into detekt:main Nov 28, 2022
@t-kameyama t-kameyama deleted the issue_5553 branch November 28, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

rules

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

Allow AtomicBoolean to be named with "is"

4 participants

@t-kameyama @3flex @BraisGabin @cortinico