Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Report proper code position in MaxLineLength #5583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BraisGabin merged 2 commits into from
Jan 18, 2023
Merged

Report proper code position in MaxLineLength #5583

BraisGabin merged 2 commits into from
Jan 18, 2023

Conversation

@BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Nov 28, 2022

Fix #5314

@github-actions github-actions bot added the rules label Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022 •
edited
Loading

Codecov Report

Merging #5583 (b04c570) into main (c18a7bb) will increase coverage by 85.89%.
The diff coverage is 87.50%.

❗ Current head b04c570 differs from pull request most recent head 4b4a736. Consider uploading reports for the commit 4b4a736 to get more accurate results

@@             Coverage Diff             @@
##             main    #5583       +/-   ##
===========================================
+ Coverage        0   85.89%   +85.89%     
- Complexity      0     3625     +3625     
===========================================
  Files           0      515      +515     
  Lines           0    12141    +12141     
  Branches        0     2166     +2166     
===========================================
+ Hits            0    10428    +10428     
- Misses          0      627      +627     
- Partials        0     1086     +1086
Impacted Files Coverage Δ
...lab/arturbosch/detekt/rules/style/MaxLineLength.kt 94.23% <87.50%> (ø)
...b/detekt/metrics/processors/ProjectLOCProcessor.kt 100.00% <0.00%> (ø)
...n/io/github/detekt/report/sarif/RuleDescriptors.kt 30.43% <0.00%> (ø)
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100.00% <0.00%> (ø)
...github/detekt/metrics/ComplexityReportGenerator.kt 85.18% <0.00%> (ø)
.../arturbosch/detekt/formatting/wrappers/Filename.kt 100.00% <0.00%> (ø)
...sch/detekt/rules/coroutines/SleepInsteadOfDelay.kt 75.86% <0.00%> (ø)
...n/kotlin/io/gitlab/arturbosch/detekt/cli/Errors.kt 100.00% <0.00%> (ø)
...itlab/arturbosch/detekt/core/extensions/Loading.kt 20.00% <0.00%> (ø)
...arturbosch/detekt/rules/empty/EmptyCodeProvider.kt 100.00% <0.00%> (ø)
... and 506 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cortinico cortinico added this to the 1.23.0 milestone Nov 29, 2022
@BraisGabin BraisGabin merged commit adf5d96 into main Jan 18, 2023
@BraisGabin BraisGabin deleted the fix-5314 branch January 18, 2023 11:19
@TWiStErRob TWiStErRob mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TWiStErRob TWiStErRob TWiStErRob left review comments

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

rules

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

MaxLineLength highlights a strange part of raw strings with escape sequences (Regex)

4 participants

@BraisGabin @TWiStErRob @cortinico