Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Force SerialVerionUID to be private #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BraisGabin merged 2 commits into from
Feb 26, 2023
Merged

Force SerialVerionUID to be private #5798

BraisGabin merged 2 commits into from
Feb 26, 2023

Conversation

@BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Feb 21, 2023

From the documentation:

It is also strongly advised that explicit serialVersionUID declarations use the private modifier where possible, since such declarations apply only to the immediately declaring class--serialVersionUID fields are not useful as inherited members.

@github-actions github-actions bot added the rules label Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited
Loading

Codecov Report

Merging #5798 (4e7cd90) into main (2367650) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #5798      +/-   ##
============================================
- Coverage     84.59%   84.59%   -0.01%     
+ Complexity     3790     3777      -13     
============================================
  Files           546      546              
  Lines         12918    12915       -3     
  Branches       2268     2268              
============================================
- Hits          10928    10925       -3     
  Misses          861      861              
  Partials       1129     1129
Impacted Files Coverage Δ
...rules/style/SerialVersionUIDInSerializableClass.kt 78.37% <0.00%> (-0.57%) ⬇️
.../detekt/rules/naming/ConstructorParameterNaming.kt 88.57% <0.00%> (-0.32%) ⬇️
...bosch/detekt/rules/naming/BooleanPropertyNaming.kt 94.11% <0.00%> (-0.17%) ⬇️
...b/arturbosch/detekt/rules/naming/FunctionNaming.kt 100.00% <0.00%> (ø)
...b/arturbosch/detekt/rules/naming/VariableNaming.kt 88.57% <0.00%> (ø)
...sch/detekt/rules/naming/FunctionParameterNaming.kt 89.28% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BraisGabin BraisGabin added this to the 1.23.0 milestone Feb 21, 2023
@BraisGabin BraisGabin force-pushed the improve-serial-version-uid branch from 020bfdf to 8dce555 Compare February 24, 2023 09:52
cortinico
cortinico approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BraisGabin @cortinico
Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt…
4e7cd90 
…/rules/style/SerialVersionUIDInSerializableClass.kt

Co-authored-by: Nicola Corti <[email protected]>
@BraisGabin BraisGabin enabled auto-merge (squash) February 26, 2023 13:07
@BraisGabin BraisGabin merged commit 30d24ea into main Feb 26, 2023
@BraisGabin BraisGabin deleted the improve-serial-version-uid branch February 26, 2023 13:18
@baseballyama baseballyama mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

rules

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

3 participants

@BraisGabin @cortinico