Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify generate documentation #5844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BraisGabin merged 7 commits into from
Mar 3, 2023
Merged

Simplify generate documentation #5844

BraisGabin merged 7 commits into from
Mar 3, 2023

Conversation

@BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Feb 26, 2023

A bit of love for generateDocumentation. I think that this PR reviewed commit by commit should be easier.

Basically what I did:

  • Remove dependencies with other tasks
  • Don't hardcode paths, use gradle
  • Reduce verbosity
  • Some other minor Boy Scouts

@github-actions github-actions bot added the build label Feb 26, 2023
@BraisGabin BraisGabin force-pushed the simplify-generateDocumentation branch from 8cdeb4d to 77ec4e5 Compare February 26, 2023 23:40
@BraisGabin BraisGabin mentioned this pull request Feb 27, 2023
Merged
@BraisGabin BraisGabin force-pushed the simplify-generateDocumentation branch from 77ec4e5 to 836ddff Compare February 27, 2023 00:23
@BraisGabin BraisGabin force-pushed the simplify-generateDocumentation branch from 836ddff to c9ac7f5 Compare February 27, 2023 00:39
@codecov
Copy link

codecov bot commented Feb 27, 2023 •
edited
Loading

Codecov Report

Merging #5844 (fc55214) into main (274e89c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #5844   +/-   ##
=========================================
  Coverage     84.59%   84.59%           
  Complexity     3784     3784           
=========================================
  Files           546      546           
  Lines         12944    12944           
  Branches       2273     2273           
=========================================
  Hits          10950    10950           
  Misses          861      861           
  Partials       1133     1133

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@BraisGabin BraisGabin force-pushed the simplify-generateDocumentation branch from c9ac7f5 to da99fcb Compare February 27, 2023 01:17
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Feb 27, 2023
@BraisGabin BraisGabin added this to the 1.23.0 milestone Feb 27, 2023
@BraisGabin BraisGabin force-pushed the simplify-generateDocumentation branch from da99fcb to 6a98a78 Compare February 27, 2023 02:02
cortinico
cortinico approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BraisGabin BraisGabin force-pushed the simplify-generateDocumentation branch from 6a98a78 to fc55214 Compare March 3, 2023 15:01
@BraisGabin BraisGabin enabled auto-merge (squash) March 3, 2023 15:01
@BraisGabin BraisGabin merged commit 7644b34 into main Mar 3, 2023
@BraisGabin BraisGabin deleted the simplify-generateDocumentation branch March 3, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

build housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

3 participants

@BraisGabin @cortinico