Make GeneratorSpec use resources #5932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5932 +/- ##
=========================================
Coverage 84.46% 84.46%
+ Complexity 3784 3783 -1
=========================================
Files 546 546
Lines 12923 12923
Branches 2268 2268
=========================================
Hits 10915 10915
Misses 877 877
Partials 1131 1131 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
79dac38 to
b3801a4
Compare
Instead of using project files create a smaller dummy projects inside test/resources.
b3801a4 to
0e07695
Compare
BraisGabin
reviewed
Mar 26, 2023
Member
BraisGabin
left a comment
There was a problem hiding this comment.
LGTM. Just a little nit on the comments.
detekt-generator/src/test/kotlin/io/gitlab/arturbosch/detekt/generator/printer/GeneratorSpec.kt
Outdated
Show resolved
Hide resolved
bed47d8 to
4a4a9cd
Compare
4a4a9cd to
af45e79
Compare
BraisGabin
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5902