Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SwallowedException: fix false positive when exception is used as a receiver #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cortinico merged 1 commit into from
May 12, 2024
Merged

SwallowedException: fix false positive when exception is used as a receiver #7288

cortinico merged 1 commit into from
May 12, 2024

Conversation

@t-kameyama
Copy link
Contributor

@t-kameyama t-kameyama commented May 11, 2024

Fixes #7281

@codecov
Copy link

codecov bot commented May 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.77%. Comparing base (633d458) to head (b3715f9).
Report is 1 commits behind head on main.

Files Patch % Lines
...osch/detekt/rules/exceptions/SwallowedException.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7288      +/-   ##
============================================
- Coverage     84.77%   84.77%   -0.01%     
+ Complexity     3990     3989       -1     
============================================
  Files           578      578              
  Lines         12027    12026       -1     
  Branches       2478     2477       -1     
============================================
- Hits          10196    10195       -1     
  Misses          606      606              
  Partials       1225     1225

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label May 12, 2024
@cortinico cortinico merged commit 5746604 into detekt:main May 12, 2024
@detekt-ci
Copy link
Collaborator

detekt-ci commented May 12, 2024

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against b3715f9

@cortinico cortinico added this to the 2.0.0 milestone May 12, 2024
@t-kameyama t-kameyama deleted the issue_7281 branch May 12, 2024 10:07
cortinico pushed a commit that referenced this pull request Aug 29, 2024
@t-kameyama @cortinico
SwallowedException: fix false positive when exception is used as a re…
37bc992 
…ceiver (#7288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

pick request Marker for PRs that should be ported to the 1.0 release branch rules

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

False positive SwallowedException when exception is used as a receiver

4 participants

@t-kameyama @detekt-ci @BraisGabin @cortinico