Fix small corner-case in "SerialVersionUIDInSerializableClass" rule, … #7346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when property was declared inside private object.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7346 +/- ##
=========================================
Coverage 84.31% 84.31%
- Complexity 4149 4151 +2
=========================================
Files 573 573
Lines 11888 11889 +1
Branches 2458 2459 +1
=========================================
+ Hits 10023 10024 +1
Misses 613 613
Partials 1252 1252 ☔ View full report in Codecov by Sentry. |
cortinico
approved these changes
Jun 5, 2024
BraisGabin
approved these changes
Jun 5, 2024
Collaborator
cortinico
pushed a commit
that referenced
this pull request
Aug 29, 2024
…when property was declared inside private object. (#7346)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when property was declared inside private object.
Your
serialVersionUIDcould be declared insideprivate companion object, and in this caseSerialVersionUIDInSerializableClassrule should not raise any violations, as declared property is private.