Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ExplicitCollectionElementAccessMethod: fix false positive when Map put has 3 arguments #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BraisGabin merged 1 commit into from
Aug 21, 2024
Merged

ExplicitCollectionElementAccessMethod: fix false positive when Map put has 3 arguments #7563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...n/kotlin/io/gitlab/arturbosch/detekt/rules/style/ExplicitCollectionElementAccessMethod.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ class ExplicitCollectionElementAccessMethod(config: Config) : Rule(
}

private fun isCallerMap(expression: KtCallExpression): Boolean {
if (expression.valueArguments.size != 2) return false
val caller = expression.getQualifiedExpressionForSelector()?.receiverExpression
val type = caller.getResolvedCall(bindingContext)?.resultingDescriptor?.returnType
if (type == null || type is ErrorType) return false // There is no caller or it can't be resolved.
Expand Down
16 changes: 16 additions & 0 deletions ...tlin/io/gitlab/arturbosch/detekt/rules/style/ExplicitCollectionElementAccessMethodSpec.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,22 @@ class ExplicitCollectionElementAccessMethodSpec {
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}

@Test
fun `does not report map put method usage with three arguments`() {
val code = """
class MyMap : java.util.HashMap<String, Int>() {
fun put(key: String, key2: String, value: Int): Int {
return value
}
}
fun main() {
val map = MyMap()
map.put("a", "b", 1)
}
""".trimIndent()
assertThat(subject.compileAndLintWithContext(env, code)).isEmpty()
}

@Test
fun `does not report map put method with used return value`() {
val code = """
Expand Down