Extract interfaces from detekt Gradle tasks #7662
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7662 +/- ##
=========================================
Coverage 84.51% 84.51%
Complexity 4136 4136
=========================================
Files 569 569
Lines 11879 11879
Branches 2465 2465
=========================================
Hits 10039 10039
Misses 595 595
Partials 1245 1245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move common detekt Gradle task parameters into interfaces.
There are lots of ways to do this of course, so I'm open to feedback & suggestions on improvements on structure & naming.
Quick overview:
DetektBase- these are detekt-specific configuration parameters. Anything used to configure detekt sits here.CommonCompilationArgs- common compiler args that apply to all compilations, including non-JVM targets. Separating fromJvmCompilationArgsmeans we can addJsCompilationArgsand others in future.JvmCompilationArgs- JVM-specific compiler argsDetektCliTool- it's unlikely we switch to tooling API for DGP 2.0.0 but separating this interface may make it easier to make the switch in future.This will evolve as there's more I'd like to do to separate concerns in future PRs:
argsparameter toDetektCliTooland use common functions to launch the application using either worker API or the current default method.It's enough though to fix #5940.