Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Dec 2, 2025

Fixes #8785

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.35%. Comparing base (286453d) to head (1fea415).
⚠️ Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
.../main/kotlin/dev/detekt/api/internal/Signatures.kt 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8886      +/-   ##
============================================
- Coverage     85.37%   85.35%   -0.02%     
  Complexity     4384     4384              
============================================
  Files           570      570              
  Lines         12567    12575       +8     
  Branches       2623     2628       +5     
============================================
+ Hits          10729    10734       +5     
- Misses          695      696       +1     
- Partials       1143     1145       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atulgpt
Copy link
Contributor Author

atulgpt commented Dec 28, 2025

Hi @BraisGabin / @schalkms can you review this PR? This will break the existing baselines and new baseline needs to be created after this PR gets merged

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me, I haven't touched this part of the codebase, so I might not be a suitable reviewer for this PR.

@atulgpt
Copy link
Contributor Author

atulgpt commented Dec 30, 2025

Excuse me, I haven't touched this part of the codebase, so I might not be a suitable reviewer for this PR.

Sorry I was not aware.. 😅

@BraisGabin
Copy link
Member

Good one! I like it

@BraisGabin BraisGabin merged commit c3b7af9 into detekt:main Dec 31, 2025
19 of 21 checks passed
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against 1fea415

@atulgpt atulgpt deleted the fixes/8785/remove-param-name-from-ctor-sig branch December 31, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LongParameterList baseline doesn't recognize signature after parameter count changes

4 participants