Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Dec 3, 2025

Fixes #8365

@3flex
Copy link
Member

3flex commented Dec 3, 2025

Can we discuss the approach & confirm on #8365 before proceeding with this PR?

There was a reason the modules were split in the first place, so we may not want to go down this path... the discussion hadn't reached a conclusion yet.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.21%. Comparing base (3e5216b) to head (9994131).
⚠️ Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
...-test/src/main/kotlin/dev/detekt/test/Resources.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8898      +/-   ##
============================================
- Coverage     85.37%   85.21%   -0.17%     
- Complexity     4384     4392       +8     
============================================
  Files           570      574       +4     
  Lines         12567    12639      +72     
  Branches       2623     2633      +10     
============================================
+ Hits          10729    10770      +41     
- Misses          695      716      +21     
- Partials       1143     1153      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atulgpt
Copy link
Contributor Author

atulgpt commented Dec 4, 2025

Can we discuss the approach & confirm on #8365 before proceeding with this PR?

There was a reason the modules were split in the first place, so we may not want to go down this path... the discussion hadn't reached a conclusion yet.

Hi from the PR it seems that we just need to remove functions which are related to detekt testing to internal module(internal folder of the dev.detekt.test should suffice here)
For that can we review the detekt-test/api/detekt-test.api file?

@3flex
Copy link
Member

3flex commented Dec 10, 2025

My comment wasn't about the implementation of the change, it was about this comment.

There may be valid reasons to keep the split. We didn't fully resolve that question or make a decision, so that should be done on the original issue first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can detekt-test and detekt-test-utils be merged?

3 participants