Silence report if containing no findings #1860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes #1854
arturbosch
reviewed
Aug 31, 2019
detekt-cli/src/test/kotlin/io/gitlab/arturbosch/detekt/cli/console/FindingsReportSpec.kt
Show resolved
Hide resolved
arturbosch
approved these changes
Aug 31, 2019
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Aug 31, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Aug 31, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Aug 31, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Aug 31, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Aug 31, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Aug 31, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Aug 31, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Aug 31, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Aug 31, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 2, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
The `FindingsReport` should not produce any output if there are no code smells at all. This fixes detekt#1854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FindingsReportshould not produce any output if there are nocode smells at all.
This fixes #1854