Print rendered report if it's null or blank #1862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prints the rendered report to the given printer only if anything needs to be rendered at all.
This prevents printing to std.out when the silent mode is activated. It prohibits behavior described in #1854
arturbosch
approved these changes
Sep 6, 2019
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Print rendered report if it's null or blank Prints the rendered report to the given printer only if anything needs to be rendered at all. * Move TestDetektion to detekt/test package * Test rendered report if it's null or blank This prevents printing to std.out when the silent mode is activated. It prohibits behavior described in detekt#1854 * Fix line.separator related test (Windows)
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Print rendered report if it's null or blank Prints the rendered report to the given printer only if anything needs to be rendered at all. * Move TestDetektion to detekt/test package * Test rendered report if it's null or blank This prevents printing to std.out when the silent mode is activated. It prohibits behavior described in detekt#1854 * Fix line.separator related test (Windows)
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Print rendered report if it's null or blank Prints the rendered report to the given printer only if anything needs to be rendered at all. * Move TestDetektion to detekt/test package * Test rendered report if it's null or blank This prevents printing to std.out when the silent mode is activated. It prohibits behavior described in detekt#1854 * Fix line.separator related test (Windows)
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Print rendered report if it's null or blank Prints the rendered report to the given printer only if anything needs to be rendered at all. * Move TestDetektion to detekt/test package * Test rendered report if it's null or blank This prevents printing to std.out when the silent mode is activated. It prohibits behavior described in detekt#1854 * Fix line.separator related test (Windows)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prints the rendered report to the given printer only if anything needs
to be rendered at all.