Make all Gradle tasks cacheable #1875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
OOM errors in CI. |
schalkms
approved these changes
Sep 1, 2019
detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektGenerateConfigTask.kt
Show resolved
Hide resolved
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 2, 2019
* Make DetektCreateBaselineTask cacheable * Make DetektGenerateConfigTask cacheable * Make IDEA tasks cacheable * Update Detekt task annotations for consistency
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 2, 2019
* Make DetektCreateBaselineTask cacheable * Make DetektGenerateConfigTask cacheable * Make IDEA tasks cacheable * Update Detekt task annotations for consistency
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 2, 2019
* Make DetektCreateBaselineTask cacheable * Make DetektGenerateConfigTask cacheable * Make IDEA tasks cacheable * Update Detekt task annotations for consistency
arturbosch
reviewed
Sep 6, 2019
detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektGenerateConfigTask.kt
Show resolved
Hide resolved
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Make DetektCreateBaselineTask cacheable * Make DetektGenerateConfigTask cacheable * Make IDEA tasks cacheable * Update Detekt task annotations for consistency
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Make DetektCreateBaselineTask cacheable * Make DetektGenerateConfigTask cacheable * Make IDEA tasks cacheable * Update Detekt task annotations for consistency
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Make DetektCreateBaselineTask cacheable * Make DetektGenerateConfigTask cacheable * Make IDEA tasks cacheable * Update Detekt task annotations for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update annotations on tasks that were not cacheable to make them cacheable.
Using
@get:on annotations is the style used in Gradle guides, and may in fact be required to get accurate results fromvalidateTaskPropertiestask, so have updated existing annotations to use thegetuse-site target.Also tweaked a couple of annotations in the Detekt task so they're correctly set on the internal & public parameters.
Fixes #1856