Only report UnsafeCallOnNullableType on actual nullable types #1886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkms
approved these changes
Sep 1, 2019
...rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnsafeCallOnNullableTypeSpec.kt
Outdated
Show resolved
Hide resolved
...rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnsafeCallOnNullableTypeSpec.kt
Outdated
Show resolved
Hide resolved
Member
Author
|
Blocked by #1880 |
arturbosch
approved these changes
Sep 12, 2019
Member
arturbosch
left a comment
There was a problem hiding this comment.
Sorry for the late merge of #1880
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
============================================
- Coverage 80.45% 80.42% -0.03%
- Complexity 1968 1969 +1
============================================
Files 326 326
Lines 5510 5513 +3
Branches 1022 1025 +3
============================================
+ Hits 4433 4434 +1
Misses 543 543
- Partials 534 536 +2
Continue to review full report at Codecov.
|
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
…#1886) * Only check !! used on nullable types * Use more appropriate method to get a type
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
…#1886) * Only check !! used on nullable types * Use more appropriate method to get a type
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…#1886) * Only check !! used on nullable types * Use more appropriate method to get a type
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…#1886) * Only check !! used on nullable types * Use more appropriate method to get a type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #880
Rule now requires type resolution.