Report PreferToOverPairSyntax only for kotlin.Pair #1905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1905 +/- ##
============================================
- Coverage 80.45% 80.42% -0.03%
- Complexity 1968 1970 +2
============================================
Files 326 326
Lines 5510 5512 +2
Branches 1022 1023 +1
============================================
Hits 4433 4433
Misses 543 543
- Partials 534 536 +2
Continue to review full report at Codecov.
|
schalkms
approved these changes
Sep 10, 2019
| } | ||
|
|
||
| it("does not report if a non-Kotlin Pair class was used") { | ||
| val code = """val pair1 = Pair(1, 2) |
Member
There was a problem hiding this comment.
val pair1 = Pair(1, 2) should be in its own line.
arturbosch
approved these changes
Sep 12, 2019
Provides automatic syntax highlighting at compileAndLintWithContext call sites.
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Report PreferToOverPairSyntax only for kotlin.Pair * Fix issues found by PreferToOverPairSyntax * Add @language annotation Provides automatic syntax highlighting at compileAndLintWithContext call sites.
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Report PreferToOverPairSyntax only for kotlin.Pair * Fix issues found by PreferToOverPairSyntax * Add @language annotation Provides automatic syntax highlighting at compileAndLintWithContext call sites.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Report PreferToOverPairSyntax only for kotlin.Pair * Fix issues found by PreferToOverPairSyntax * Add @language annotation Provides automatic syntax highlighting at compileAndLintWithContext call sites.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Report PreferToOverPairSyntax only for kotlin.Pair * Fix issues found by PreferToOverPairSyntax * Add @language annotation Provides automatic syntax highlighting at compileAndLintWithContext call sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1066
Rule now requires type resolution.
Blocked by #1880.