Fix TimeoutCancellationException - downgrade Spek#1903
Merged
3flex merged 1 commit intodetekt:masterfrom Sep 8, 2019
schalkms:timeout-spek
Merged
Fix TimeoutCancellationException - downgrade Spek#19033flex merged 1 commit intodetekt:masterfrom schalkms:timeout-spek
3flex merged 1 commit intodetekt:masterfrom
schalkms:timeout-spek
Conversation
Spek 2.0.3 introduced test timeouts. (https://github.com/spekframework/spek/releases/tag/2.0.3) The default timeout is 10 seconds per test case. Detekt's rule-tests easily reach this limit when 1. setting up 8 `KotlinScriptEngine's` for compiling test snippets. 2. the (CI) machines are under heavy load This results in the following exception as happened in commit 9691e0d. kotlinx.coroutines.TimeoutCancellationException: Timed out waiting for 10000 ms Unfortunately, Spek doesn't allow to set a global timeout (yet). See: spekframework/spek#769 Setting a custom timeout on each test block is not what we want. Therefore, this commit downgrades Spek to version 2.0.2.
3flex
approved these changes
Sep 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
=========================================
Coverage 80.43% 80.43%
Complexity 1950 1950
=========================================
Files 325 325
Lines 5490 5490
Branches 1013 1013
=========================================
Hits 4416 4416
Misses 545 545
Partials 529 529Continue to review full report at Codecov.
|
Member
|
Ah I see, sorry for the spam in both PRs :) |
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
Spek 2.0.3 introduced test timeouts. (https://github.com/spekframework/spek/releases/tag/2.0.3) The default timeout is 10 seconds per test case. Detekt's rule-tests easily reach this limit when 1. setting up 8 `KotlinScriptEngine's` for compiling test snippets. 2. the (CI) machines are under heavy load This results in the following exception as happened in commit 9691e0d. kotlinx.coroutines.TimeoutCancellationException: Timed out waiting for 10000 ms Unfortunately, Spek doesn't allow to set a global timeout (yet). See: spekframework/spek#769 Setting a custom timeout on each test block is not what we want. Therefore, this commit downgrades Spek to version 2.0.2.
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
Spek 2.0.3 introduced test timeouts. (https://github.com/spekframework/spek/releases/tag/2.0.3) The default timeout is 10 seconds per test case. Detekt's rule-tests easily reach this limit when 1. setting up 8 `KotlinScriptEngine's` for compiling test snippets. 2. the (CI) machines are under heavy load This results in the following exception as happened in commit 9691e0d. kotlinx.coroutines.TimeoutCancellationException: Timed out waiting for 10000 ms Unfortunately, Spek doesn't allow to set a global timeout (yet). See: spekframework/spek#769 Setting a custom timeout on each test block is not what we want. Therefore, this commit downgrades Spek to version 2.0.2.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
Spek 2.0.3 introduced test timeouts. (https://github.com/spekframework/spek/releases/tag/2.0.3) The default timeout is 10 seconds per test case. Detekt's rule-tests easily reach this limit when 1. setting up 8 `KotlinScriptEngine's` for compiling test snippets. 2. the (CI) machines are under heavy load This results in the following exception as happened in commit 9691e0d. kotlinx.coroutines.TimeoutCancellationException: Timed out waiting for 10000 ms Unfortunately, Spek doesn't allow to set a global timeout (yet). See: spekframework/spek#769 Setting a custom timeout on each test block is not what we want. Therefore, this commit downgrades Spek to version 2.0.2.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
Spek 2.0.3 introduced test timeouts. (https://github.com/spekframework/spek/releases/tag/2.0.3) The default timeout is 10 seconds per test case. Detekt's rule-tests easily reach this limit when 1. setting up 8 `KotlinScriptEngine's` for compiling test snippets. 2. the (CI) machines are under heavy load This results in the following exception as happened in commit 9691e0d. kotlinx.coroutines.TimeoutCancellationException: Timed out waiting for 10000 ms Unfortunately, Spek doesn't allow to set a global timeout (yet). See: spekframework/spek#769 Setting a custom timeout on each test block is not what we want. Therefore, this commit downgrades Spek to version 2.0.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spek 2.0.3 introduced test timeouts.
(https://github.com/spekframework/spek/releases/tag/2.0.3)
The default timeout is 10 seconds per test case.
Detekt's rule-tests easily reach this limit when
KotlinScriptEngine'sfor compiling test snippets.This results in the following exception as happened in commit 9691e0d.
kotlinx.coroutines.TimeoutCancellationException:
Timed out waiting for 10000 ms
Unfortunately, Spek doesn't allow to set a global timeout (yet).
See: spekframework/spek#769
Setting a custom timeout on each test block is not what we want.
Therefore, this commit downgrades Spek to version 2.0.2.