Fix NestedBlockDepth false negative #2086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2086 +/- ##
============================================
+ Coverage 80.86% 80.86% +<.01%
Complexity 2010 2010
============================================
Files 336 336
Lines 5779 5780 +1
Branches 1060 1060
============================================
+ Hits 4673 4674 +1
Misses 546 546
Partials 560 560
Continue to review full report at Codecov.
|
schalkms
reviewed
Nov 14, 2019
...t-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt
Outdated
Show resolved
Hide resolved
...t-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt
Outdated
Show resolved
Hide resolved
arturbosch
approved these changes
Nov 16, 2019
Member
|
Thanks again for the great PR.It kinda feels wrong to hold back all the good improvements and fixes from the community :/. I try to finish #1921 this WE and release a new version soon. |
…/complexity/NestedBlockDepthSpec.kt Co-Authored-By: M Schalk <[email protected]>
…/complexity/NestedBlockDepthSpec.kt Co-Authored-By: M Schalk <[email protected]>
Member
Author
|
Done. Sorry for the late update. Busy days. |
schalkms
approved these changes
Nov 16, 2019
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Fix NestedBlockDepth * Update detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt Co-Authored-By: M Schalk <[email protected]> * Update detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt Co-Authored-By: M Schalk <[email protected]>
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Fix NestedBlockDepth * Update detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt Co-Authored-By: M Schalk <[email protected]> * Update detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt Co-Authored-By: M Schalk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2085
I also improve the tests a bit simplifing the code and using
compileAndLint()