Add config flag ignoreOverridden to ConstructorParameterNaming #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2097 +/- ##
============================================
+ Coverage 80.48% 80.49% +0.01%
- Complexity 2018 2020 +2
============================================
Files 336 336
Lines 5802 5805 +3
Branches 1064 1065 +1
============================================
+ Hits 4670 4673 +3
Misses 564 564
Partials 568 568
Continue to review full report at Codecov.
|
arturbosch
approved these changes
Nov 27, 2019
arturbosch
pushed a commit
that referenced
this pull request
Dec 5, 2019
* Add ignore override in constructor parameters * Regenerate documentation
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…t#2097) * Add ignore override in constructor parameters * Regenerate documentation
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…t#2097) * Add ignore override in constructor parameters * Regenerate documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should wait until #2094 is merged.
This PR tries to fix this:
If we override a property of an interface in a constructor we should ignore the naming check by default.