Lazy init KotlinScriptEnginePool #2126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only initializes the Jsr223 KotlinScriptEngines when they are used for the first time. This helps to reduce the test execution time when rules don't use these engines. reference: #2095
Codecov Report
@@ Coverage Diff @@
## master #2126 +/- ##
=========================================
Coverage 80.62% 80.62%
Complexity 2015 2015
=========================================
Files 336 336
Lines 5802 5802
Branches 1057 1057
=========================================
Hits 4678 4678
Misses 563 563
Partials 561 561Continue to review full report at Codecov.
|
3flex
approved these changes
Nov 26, 2019
arturbosch
pushed a commit
that referenced
this pull request
Dec 5, 2019
This only initializes the Jsr223 KotlinScriptEngines when they are used for the first time. This helps to reduce the test execution time when rules don't use these engines. reference: #2095
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
This only initializes the Jsr223 KotlinScriptEngines when they are used for the first time. This helps to reduce the test execution time when rules don't use these engines. reference: detekt#2095
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
This only initializes the Jsr223 KotlinScriptEngines when they are used for the first time. This helps to reduce the test execution time when rules don't use these engines. reference: detekt#2095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only initializes the Jsr223 KotlinScriptEngines when they are used
for the first time. This helps to reduce the test execution time when
rules don't use these engines.
reference: #2095