Don't compile test snippets (bindingContext) #2137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2137 +/- ##
========================================
Coverage 80.5% 80.5%
Complexity 2015 2015
========================================
Files 336 336
Lines 5802 5802
Branches 1064 1064
========================================
Hits 4671 4671
Misses 564 564
Partials 567 567Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Nov 28, 2019
arturbosch
approved these changes
Nov 29, 2019
Member
arturbosch
left a comment
There was a problem hiding this comment.
👍
lets wait after 1.2.1 to merge this please.
Member
Author
|
Yes. This further speeds up detekt's CI and the tests runs on our local dev machines. The Jsr223 compiles engines aren't even created at startup anymore if the environment variable |
arturbosch
pushed a commit
that referenced
this pull request
Dec 5, 2019
follow-up: #2105 This further speeds up detekt's CI and the tests runs on our local dev machines. The Jsr223 compiles engines aren't even created at startup anymore if the environment variable compile-snippet-tests is set to false.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
follow-up: detekt#2105 This further speeds up detekt's CI and the tests runs on our local dev machines. The Jsr223 compiles engines aren't even created at startup anymore if the environment variable compile-snippet-tests is set to false.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
follow-up: detekt#2105 This further speeds up detekt's CI and the tests runs on our local dev machines. The Jsr223 compiles engines aren't even created at startup anymore if the environment variable compile-snippet-tests is set to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up: #2105