Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add disposing Kotlin environment. #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schalkms merged 2 commits into from
Jan 10, 2020
Merged

Add disposing Kotlin environment. #2238

schalkms merged 2 commits into from
Jan 10, 2020

Conversation

@arturdryomov
Copy link
Contributor

@arturdryomov arturdryomov commented Jan 10, 2020

artem-zinnatullin
artem-zinnatullin approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@artem-zinnatullin
Copy link
Contributor

artem-zinnatullin commented Jan 10, 2020

@arturbosch if possible can you please ship a new release once this is merged? Thanks :)

@codecov-io
Copy link

codecov-io commented Jan 10, 2020 •
edited
Loading

Codecov Report

Merging #2238 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2238      +/-   ##
============================================
+ Coverage     81.37%   81.38%   +<.01%     
- Complexity     2073     2074       +1     
============================================
  Files           343      343              
  Lines          5981     5984       +3     
  Branches       1086     1086              
============================================
+ Hits           4867     4870       +3     
  Misses          532      532              
  Partials        582      582
Impacted Files Coverage Δ Complexity Δ
...itlab/arturbosch/detekt/core/ProcessingSettings.kt 89.83% <100%> (+0.17%) 19 <1> (+1) ⬆️
.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt 87.23% <100%> (+0.27%) 10 <0> (ø) ⬇️
...osch/detekt/api/internal/KotlinEnvironmentUtils.kt 86.27% <100%> (+0.27%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44f8c2...c365e41. Read the comment docs.

@schalkms schalkms merged commit 5dfe7c5 into detekt:master Jan 10, 2020
@artem-zinnatullin
Copy link
Contributor

artem-zinnatullin commented Jan 11, 2020

My apologies, didn't realize you (@schalkms) were also a core maintainer, I thought only @arturbosch was :)

@arturdryomov arturdryomov deleted the ad/dispose-kotlin-environment branch January 11, 2020 07:15
@arturbosch arturbosch added this to the 1.4.0 milestone Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schalkms schalkms schalkms approved these changes

+1 more reviewer

@artem-zinnatullin artem-zinnatullin artem-zinnatullin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

OOM on multiple invocations

5 participants

@arturdryomov @artem-zinnatullin @codecov-io @schalkms @arturbosch