Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test some edge cases in detekt-api #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturbosch merged 1 commit into from
Jan 14, 2020
Merged

Test some edge cases in detekt-api #2256

arturbosch merged 1 commit into from
Jan 14, 2020

Conversation

@schalkms
Copy link
Member

@schalkms schalkms commented Jan 13, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 13, 2020 •
edited
Loading

Codecov Report

Merging #2256 into master will increase coverage by 0.19%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2256      +/-   ##
============================================
+ Coverage     81.26%   81.45%   +0.19%     
- Complexity     2101     2104       +3     
============================================
  Files           348      348              
  Lines          6020     6018       -2     
  Branches       1102     1102              
============================================
+ Hits           4892     4902      +10     
+ Misses          534      531       -3     
+ Partials        594      585       -9
Impacted Files Coverage Δ Complexity Δ
...rbosch/detekt/api/internal/CyclomaticComplexity.kt 94.33% <33.33%> (-0.21%) 23 <0> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/api/Debt.kt 100% <0%> (+6.66%) 6% <0%> (ø) ⬇️
...in/io/gitlab/arturbosch/detekt/api/SplitPattern.kt 96.29% <0%> (+11.11%) 20% <0%> (+3%) ⬆️
...ch/detekt/api/internal/ValidatableConfiguration.kt 100% <0%> (+13.63%) 0% <0%> (ø) ⬇️
...io/gitlab/arturbosch/detekt/api/RuleSetProvider.kt 100% <0%> (+28.57%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebff6aa...7ac2ab6. Read the comment docs.

arturbosch
arturbosch approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, thanks!

@arturbosch arturbosch added this to the 1.5.0 milestone Jan 14, 2020
@arturbosch arturbosch merged commit 0f74942 into detekt:master Jan 14, 2020
@schalkms schalkms deleted the detekt-api-tests branch January 15, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@arturbosch arturbosch arturbosch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@schalkms @codecov-io @BraisGabin @arturbosch