Stop using kotlin-reflect #2405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2405 +/- ##
=========================================
Coverage 82.88% 82.88%
Complexity 2147 2147
=========================================
Files 353 353
Lines 6123 6123
Branches 1116 1116
=========================================
Hits 5075 5075
Misses 475 475
Partials 573 573Continue to review full report at Codecov.
|
arturbosch
approved these changes
Mar 5, 2020
arturbosch
added a commit
that referenced
this pull request
Apr 19, 2020
This reverts commit 69a0dda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Kotlin 1.3.70 it's no longer necessary to use the reflect library for some code that previously required it (e.g. kClass.simpleName).
Fortunately detekt doesn't need this library anymore so it can be removed as a dependency.