Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Require CI to pass to run codecov #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturbosch merged 1 commit into from
Mar 28, 2020
Merged

Require CI to pass to run codecov #2546

arturbosch merged 1 commit into from
Mar 28, 2020

Conversation

@schalkms
Copy link
Member

@schalkms schalkms commented Mar 28, 2020

This commit removes the 'require_ci_to_pass: no' declaration.

@schalkms
Require CI to pass to run codecov
56564c6 
This commit removes the 'require_ci_to_pass: no' declaration.
@schalkms schalkms mentioned this pull request Mar 28, 2020
Merged
arturbosch
arturbosch approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will see :)

@arturbosch arturbosch added this to the 1.8.0 milestone Mar 28, 2020
@codecov-io
Copy link

codecov-io commented Mar 28, 2020 •
edited
Loading

Codecov Report

Merging #2546 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2546      +/-   ##
============================================
+ Coverage     80.83%   80.85%   +0.01%     
  Complexity     2265     2265              
============================================
  Files           376      376              
  Lines          7353     7355       +2     
  Branches       1206     1206              
============================================
+ Hits           5944     5947       +3     
+ Misses          810      809       -1     
  Partials        599      599
Impacted Files Coverage Δ Complexity Δ
...itlab/arturbosch/detekt/generator/GeneratorArgs.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...etekt/rules/complexity/StringLiteralDuplication.kt 95.55% <0.00%> (+0.20%) 5.00% <0.00%> (ø%)
...lab/arturbosch/detekt/api/internal/PathMatchers.kt 55.55% <0.00%> (+1.01%) 0.00% <0.00%> (ø%)
...n/kotlin/io/gitlab/arturbosch/detekt/api/Metric.kt 85.71% <0.00%> (+1.50%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e1882...56564c6. Read the comment docs.

@arturbosch arturbosch merged commit 2bd32ce into detekt:master Mar 28, 2020
@schalkms schalkms deleted the codecov-rootconf branch March 29, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturbosch arturbosch arturbosch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.7.3

Development

Successfully merging this pull request may close these issues.

3 participants

@schalkms @codecov-io @arturbosch