New Rule: UnnecessarySafeCall #2574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2574 +/- ##
============================================
+ Coverage 25.11% 25.17% +0.06%
- Complexity 392 393 +1
============================================
Files 378 378
Lines 7391 7399 +8
Branches 1221 1222 +1
============================================
+ Hits 1856 1863 +7
- Misses 5404 5405 +1
Partials 131 131
Continue to review full report at Codecov.
|
schalkms
reviewed
Apr 3, 2020
detekt-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt
Outdated
Show resolved
Hide resolved
detekt-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt
Outdated
Show resolved
Hide resolved
detekt-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt
Outdated
Show resolved
Hide resolved
detekt-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt
Outdated
Show resolved
Hide resolved
detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnnecessarySafeCallSpec.kt
Outdated
Show resolved
Hide resolved
…/bugs/UnnecessarySafeCall.kt Co-Authored-By: M Schalk <[email protected]>
…/bugs/UnnecessarySafeCallSpec.kt Co-Authored-By: M Schalk <[email protected]>
…/bugs/UnnecessarySafeCall.kt Co-Authored-By: M Schalk <[email protected]>
…/bugs/UnnecessarySafeCall.kt Co-Authored-By: M Schalk <[email protected]>
schalkms
approved these changes
Apr 4, 2020
schalkms
reviewed
Apr 4, 2020
detekt-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt
Outdated
Show resolved
Hide resolved
…/bugs/UnnecessarySafeCall.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
UnnecessarySafeCallrule, as suggested in #2572