Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MagicNumber>ignoredNumbers allow yaml list #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturbosch merged 2 commits into from
Apr 14, 2020
Merged

MagicNumber>ignoredNumbers allow yaml list #2600

arturbosch merged 2 commits into from
Apr 14, 2020

Conversation

@BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Apr 13, 2020

This PR is one in a serie of PRs to implement #2498

@BraisGabin BraisGabin mentioned this pull request Apr 13, 2020
Merged
@codecov-io
Copy link

codecov-io commented Apr 13, 2020 •
edited
Loading

Codecov Report

Merging #2600 into master will increase coverage by 1.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2600      +/-   ##
============================================
+ Coverage     25.17%   26.84%   +1.67%     
+ Complexity      395      393       -2     
============================================
  Files           379      379              
  Lines          7420     6723     -697     
  Branches       1225     1224       -1     
============================================
- Hits           1868     1805      -63     
+ Misses         5423     4789     -634     
  Partials        129      129
Impacted Files Coverage Δ Complexity Δ
...itlab/arturbosch/detekt/rules/style/MagicNumber.kt 32.46% <100.00%> (-0.46%) 3.00 <0.00> (ø)
...itlab/arturbosch/detekt/api/internal/Validation.kt 33.33% <0.00%> (-16.67%) 0.00% <0.00%> (ø%)
.../gitlab/arturbosch/detekt/cli/console/Colorizer.kt 61.53% <0.00%> (-9.90%) 0.00% <0.00%> (ø%)
...h/detekt/api/internal/DisabledAutoCorrectConfig.kt 55.55% <0.00%> (-8.09%) 4.00% <0.00%> (ø%)
...otlin/io/gitlab/arturbosch/detekt/core/TaskPool.kt 33.33% <0.00%> (-6.67%) 3.00% <0.00%> (ø%)
...in/io/gitlab/arturbosch/detekt/api/SingleAssign.kt 60.00% <0.00%> (-6.67%) 3.00% <0.00%> (ø%)
...in/kotlin/io/gitlab/arturbosch/detekt/api/Issue.kt 50.00% <0.00%> (-5.56%) 2.00% <0.00%> (ø%)
...n/io/gitlab/arturbosch/detekt/api/ConsoleReport.kt 75.00% <0.00%> (-5.00%) 4.00% <0.00%> (ø%)
...tlab/arturbosch/detekt/api/internal/EmptyConfig.kt 66.66% <0.00%> (-4.77%) 4.00% <0.00%> (ø%)
...in/io/gitlab/arturbosch/detekt/cli/OutputFacade.kt 77.77% <0.00%> (-4.05%) 5.00% <0.00%> (ø%)
... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6591e...69d43ae. Read the comment docs.

@arturbosch arturbosch added this to the 1.8.0 milestone Apr 14, 2020
@arturbosch arturbosch merged commit a93a46b into detekt:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturbosch arturbosch arturbosch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@BraisGabin @codecov-io @arturbosch