Add cognitive complexity in complexity report #2727
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2727 +/- ##
============================================
+ Coverage 80.58% 80.63% +0.04%
- Complexity 2317 2321 +4
============================================
Files 379 380 +1
Lines 6960 6971 +11
Branches 1260 1259 -1
============================================
+ Hits 5609 5621 +12
Misses 724 724
+ Partials 627 626 -1
Continue to review full report at Codecov.
|
schalkms
left a comment
There was a problem hiding this comment.
adding many small changes to many files
I'm counting 5 files that were changed in the production code. IMHO this is not too bad.
| } | ||
| } | ||
|
|
||
| private class MetricResults : Detektion { |
There was a problem hiding this comment.
I think there's already a suitable test overload for Detektion in the codebase.
There was a problem hiding this comment.
Yes, there is!
It's a bit unfortunately here, but I do no want to depend on detekt-test.
This duplication can be merged after we clean up the api a bit.
I've noticed that adding one additional project metric to the complexity can be quite challenging - adding many small changes to many files (Shotgun Surgery) and it can't be extended by users.
I think we have here an opportunity for a more generic approach which is out of scope for this but may be an idea for #2680.