Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove deprecated HierarchicalConfig which could lead to OOM when reusing Config objects #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturbosch merged 1 commit into from
Jun 5, 2020
Merged

Remove deprecated HierarchicalConfig which could lead to OOM when reusing Config objects #2768

arturbosch merged 1 commit into from
Jun 5, 2020

Conversation

@arturbosch
Copy link
Member

@arturbosch arturbosch commented Jun 4, 2020

We have deprecated it three minor versions ago in (1.7.0).

@arturbosch arturbosch added this to the 1.10.0 milestone Jun 4, 2020
@arturbosch arturbosch added the migration Marker to add a migration step in the changelog label Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #2768 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2768      +/-   ##
============================================
+ Coverage     80.53%   80.56%   +0.02%     
  Complexity     2319     2319              
============================================
  Files           385      385              
  Lines          6961     6955       -6     
  Branches       1261     1261              
============================================
- Hits           5606     5603       -3     
+ Misses          727      724       -3     
  Partials        628      628
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/io/gitlab/arturbosch/detekt/api/Config.kt 100.00% <100.00%> (+5.88%) 0.00 <0.00> (ø)
...itlab/arturbosch/detekt/api/internal/BaseConfig.kt 96.15% <100.00%> (ø) 12.00 <0.00> (ø)
...tlab/arturbosch/detekt/api/internal/EmptyConfig.kt 80.00% <100.00%> (+13.33%) 4.00 <1.00> (ø)
...itlab/arturbosch/detekt/api/internal/YamlConfig.kt 81.48% <100.00%> (+1.48%) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92acdbc...68888d2. Read the comment docs.

@arturbosch arturbosch merged commit af94c24 into master Jun 5, 2020
@arturbosch arturbosch deleted the remove-hierarchical-config branch June 5, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@schalkms schalkms schalkms approved these changes

Assignees

No one assigned

Labels

migration Marker to add a migration step in the changelog

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@arturbosch @BraisGabin @schalkms