Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unify extension debug printing #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturbosch merged 1 commit into from
Jun 5, 2020
Merged

Unify extension debug printing #2770

arturbosch merged 1 commit into from
Jun 5, 2020

Conversation

@arturbosch
Copy link
Member

@arturbosch arturbosch commented Jun 4, 2020 •
edited
Loading

Unfortunately letting RuleSetProvider extend Extension is not backwards compatible.

@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jun 4, 2020
@arturbosch arturbosch added this to the 1.10.0 milestone Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #2770 into master will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2770      +/-   ##
============================================
- Coverage     80.53%   80.49%   -0.04%     
  Complexity     2319     2319              
============================================
  Files           385      385              
  Lines          6961     6957       -4     
  Branches       1261     1261              
============================================
- Hits           5606     5600       -6     
- Misses          727      728       +1     
- Partials        628      629       +1
Impacted Files Coverage Δ Complexity Δ
...otlin/io/gitlab/arturbosch/detekt/api/Extension.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
...itlab/arturbosch/detekt/core/extensions/Loading.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...io/gitlab/arturbosch/detekt/core/RuleSetLocator.kt 83.33% <66.66%> (-16.67%) 6.00 <3.00> (ø)
...lab/arturbosch/detekt/core/FileProcessorLocator.kt 100.00% <100.00%> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92acdbc...2876f97. Read the comment docs.

@arturbosch arturbosch merged commit 3905203 into master Jun 5, 2020
@arturbosch arturbosch deleted the debug-improvements branch June 5, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees

No one assigned

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@arturbosch @BraisGabin