Smarter Caching on Github Actions #2788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2788 +/- ##
=========================================
Coverage 80.51% 80.51%
Complexity 2324 2324
=========================================
Files 386 386
Lines 6955 6955
Branches 1262 1262
=========================================
Hits 5600 5600
Misses 725 725
Partials 630 630 Continue to review full report at Codecov.
|
schalkms
approved these changes
Jun 12, 2020
arturbosch
approved these changes
Jun 13, 2020
Member
arturbosch
left a comment
There was a problem hiding this comment.
👍 so lets wait for the bom PR then
00ebf8b to
3bb2890
Compare
schalkms
approved these changes
Jun 13, 2020
BraisGabin
approved these changes
Jun 13, 2020
Member
Author
|
CI is red because of #2795 |
3bb2890 to
2a9c55e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our Github Actions setup relies on a static key for caching.
This means that we restore an old Gradle cache that doesn't contain the version of Gradle we need (it gets re-downloaded every time).
Given that we don't have a lockfile (should we consider it?), I'm hashing 'buildSrc/src/main/kotlin/Versions.kt' and adding it to the cache key. So the cache will be partially invalidated whenever we release a new version (or whenever we bump a library).