OptionalUnit: don't report it if Unit is used as an expression #2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2886 +/- ##
============================================
- Coverage 80.19% 80.19% -0.01%
- Complexity 2413 2425 +12
============================================
Files 421 421
Lines 7353 7368 +15
Branches 1341 1349 +8
============================================
+ Hits 5897 5909 +12
- Misses 760 761 +1
- Partials 696 698 +2
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Jul 22, 2020
Member
BraisGabin
left a comment
There was a problem hiding this comment.
Good job! I really like all the corner cases that you covered in the tests 👏🏻👏🏻
| .filter { it is KtNameReferenceExpression && it.text == UNIT } | ||
| val statements = expression.statements | ||
| val lastStatement = statements.lastOrNull() ?: return | ||
| statements |
Member
There was a problem hiding this comment.
Couls these if/return be replaced with an if/else?
Contributor
Author
There was a problem hiding this comment.
I've replaced these with 'when' expression.
schalkms
approved these changes
Jul 22, 2020
BraisGabin
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2452