Implement a proof of concept using the Gradle worker api #2896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
By now Checkstyle, PMD, and CodeNarc are all now implemented via the worker API. Does that open new opportunities for Detekt? |
Member
This just got merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to use the worker api to mitigate our classloader caching problems when changing detekt artifacts.
However the worker api has it's own shortcomings. It does for example not allow to cache classloaders and brings us back the jvm startup overhead.
This will bring us back to the old javaexec-implementation - performance-wise.
gradle/gradle#8221
gradle/gradle#9196
Imo this is also the reason why Gradle internal quality plugins haven't yet migrated to the worker api:
gradle/gradle#9196
The quality plugins use an
IsolatedAntBuilderwhich uses internally aClassPathToClassLoaderCache.I open and close this PR for documentation purposes.
We will need to stay on our custom classloader cache and call the cli module reflectively for the best performance.