Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Generate output report config parts for config validation to know the properties #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturbosch merged 1 commit into from
Aug 1, 2020
Merged

Generate output report config parts for config validation to know the properties #2907

arturbosch merged 1 commit into from
Aug 1, 2020

Conversation

@arturbosch
Copy link
Member

@arturbosch arturbosch commented Jul 30, 2020

Closes #2891

@arturbosch arturbosch added this to the 1.10.1 milestone Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited
Loading

Codecov Report

Merging #2907 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2907      +/-   ##
============================================
- Coverage     80.18%   80.16%   -0.02%     
- Complexity     2426     2430       +4     
============================================
  Files           421      421              
  Lines          7378     7387       +9     
  Branches       1350     1354       +4     
============================================
+ Hits           5916     5922       +6     
- Misses          762      764       +2     
- Partials        700      701       +1
Impacted Files Coverage Δ Complexity Δ
...ekt/generator/printer/rulesetpage/ConfigPrinter.kt 78.26% <100.00%> (+1.51%) 9.00 <1.00> (+1.00)
...turbosch/detekt/rules/KtClassOrObjectExtensions.kt 40.00% <0.00%> (-26.67%) 0.00% <0.00%> (ø%)
...lab/arturbosch/detekt/core/FileProcessorLocator.kt 69.23% <0.00%> (-10.77%) 5.00% <0.00%> (ø%)
...tlab/arturbosch/detekt/rules/style/UseDataClass.kt 76.36% <0.00%> (+1.81%) 38.00% <0.00%> (+2.00%)
...ab/arturbosch/detekt/cli/DetektProgressListener.kt 83.33% <0.00%> (+3.33%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c457917...5001b86. Read the comment docs.

@arturbosch arturbosch force-pushed the print-output-reports branch from 055272f to 7fb2591 Compare July 30, 2020 08:39
@arturbosch arturbosch force-pushed the print-output-reports branch from 7fb2591 to 5001b86 Compare July 30, 2020 08:41
schalkms
schalkms approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I could now reproduce the problem locally.
Can we somehow prevent this problem from happening in the future?

@arturbosch
Copy link
Member Author

arturbosch commented Aug 1, 2020

Good! I could now reproduce the problem locally.
Can we somehow prevent this problem from happening in the future?

I would really like to remove these parts from the config ...

@arturbosch arturbosch merged commit 05da2a7 into master Aug 1, 2020
@arturbosch arturbosch deleted the print-output-reports branch August 1, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@cortinico cortinico cortinico approved these changes

@schalkms schalkms schalkms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.11.0-RC1

Development

Successfully merging this pull request may close these issues.

error in output-reports config

5 participants

@arturbosch @BraisGabin @cortinico @schalkms