Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add new rule: LibraryEntitiesCannotBePublic #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturbosch merged 10 commits into from
Aug 11, 2020
Merged

Add new rule: LibraryEntitiesCannotBePublic #2959

arturbosch merged 10 commits into from
Aug 11, 2020

Conversation

@VovaStelmashchuk
Copy link
Contributor

@VovaStelmashchuk VovaStelmashchuk commented Aug 10, 2020

Close issue #2943

arturbosch
arturbosch approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
What is your opinion on extending this rule for top level functions?

@arturbosch arturbosch added this to the 1.11.0 milestone Aug 10, 2020
@VovaStelmashchuk
Copy link
Contributor Author

VovaStelmashchuk commented Aug 10, 2020

Thanks for the contribution.
What is your opinion on extending this rule for top level functions?

We don't use top level function in our case. But I think it great idea for detekt. Do you want to see this in the current PR?

@arturbosch
Copy link
Member

arturbosch commented Aug 10, 2020

Thanks for the contribution.
What is your opinion on extending this rule for top level functions?

We don't use top level function in our case. But I think it great idea for detekt. Do you want to see this in the current PR?

Sure, should be just a small change :), thanks!

@codecov
Copy link

codecov bot commented Aug 10, 2020 •
edited
Loading

Codecov Report

Merging #2959 into master will increase coverage by 0.01%.
The diff coverage is 85.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2959      +/-   ##
============================================
+ Coverage     80.24%   80.25%   +0.01%     
- Complexity     2455     2465      +10     
============================================
  Files           422      423       +1     
  Lines          7420     7440      +20     
  Branches       1357     1358       +1     
============================================
+ Hits           5954     5971      +17     
- Misses          762      763       +1     
- Partials        704      706       +2
Impacted Files Coverage Δ Complexity Δ
...kt/rules/style/LibraryEntitiesShouldNotBePublic.kt 84.21% <84.21%> (ø) 10.00 <10.00> (?)
...rturbosch/detekt/rules/style/StyleGuideProvider.kt 100.00% <100.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc769b5...9f32576. Read the comment docs.

@VovaStelmashchuk
Copy link
Contributor Author

VovaStelmashchuk commented Aug 11, 2020 •
edited
Loading

@arturbosch I added check for top level function. All checks are green now. I recommend to use squash for merge the PR.

@arturbosch arturbosch merged commit 3eba7f1 into detekt:master Aug 11, 2020
@arturbosch
Copy link
Member

arturbosch commented Aug 11, 2020

@arturbosch I added check for top level function. All checks are green now. I recommend to use squash for merge the PR.

Thanks! We squash every PR :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturbosch arturbosch arturbosch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@VovaStelmashchuk @arturbosch