Gradle plugin fixes #2986
Merged
Gradle plugin fixes #2986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
3flex
commented
Aug 19, 2020
- Stop declaring unnecessary dependencies
- Correct the generated test Gradle build files so they're valid
- Remove unused file
schalkms
reviewed
Aug 19, 2020
Member
schalkms
left a comment
There was a problem hiding this comment.
Long time no hear! Thanks for this pr!
The previous commit uncovers a problem with the Gradle build files that are being generated for tests, since a default Kotlin version is no longer declared on the classpath, and the Kotlin plugin cannot be applied without a specific version. Since the Kotlin plugin is not currently used in any tests, and hard coding a Kotlin version adds an additional maintenance burden, it's better to remove it for now. The java-library plugin is added instead so the "implementation" and "api" configurations will still be available for dependency declaration in tests.
ca5c0f1 to
0abd300
Compare
Codecov Report
@@ Coverage Diff @@
## master #2986 +/- ##
=========================================
Coverage 80.29% 80.29%
Complexity 2478 2478
=========================================
Files 424 424
Lines 7479 7479
Branches 1370 1370
=========================================
Hits 6005 6005
Misses 760 760
Partials 714 714 Continue to review full report at Codecov.
|
arturbosch
approved these changes
Aug 19, 2020
schalkms
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.