Fix MaxLineLengthSuppressed ignoring @Suppress annotation on class #3164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3164 +/- ##
============================================
- Coverage 79.51% 79.47% -0.04%
+ Complexity 2599 2596 -3
============================================
Files 437 437
Lines 7865 7860 -5
Branches 1497 1498 +1
============================================
- Hits 6254 6247 -7
- Misses 817 818 +1
- Partials 794 795 +1
Continue to review full report at Codecov.
|
schalkms
approved these changes
Oct 22, 2020
arturbosch
pushed a commit
that referenced
this pull request
Nov 15, 2020
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3136
The
MaxLineLengthrule was failing to pickup the parentKtElementwhen reporting a line from a long comment. This caused the@Suppressannotation on the class to be ignored.