Fix false positive when to is used to create a pair within a function
#3178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
============================================
- Coverage 79.58% 79.56% -0.02%
- Complexity 2610 2613 +3
============================================
Files 439 439
Lines 7935 7938 +3
Branches 1511 1512 +1
============================================
+ Hits 6315 6316 +1
Misses 820 820
- Partials 800 802 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
The code coverage for the class, although it fails in CI, when run locally gives 100% |
BraisGabin
approved these changes
Oct 27, 2020
BraisGabin
approved these changes
Oct 27, 2020
cortinico
approved these changes
Oct 27, 2020
schalkms
approved these changes
Oct 27, 2020
arturbosch
pushed a commit
that referenced
this pull request
Nov 15, 2020
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3177
Pairis used within the callExpression before reportingPairandtowithin a function