Fix detektBaseline task filtering .java files #3185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3185 +/- ##
============================================
+ Coverage 79.53% 79.55% +0.01%
Complexity 2631 2631
============================================
Files 440 440
Lines 7966 7964 -2
Branches 1521 1521
============================================
Hits 6336 6336
+ Misses 820 818 -2
Partials 810 810
Continue to review full report at Codecov.
|
schalkms
approved these changes
Oct 29, 2020
arturbosch
pushed a commit
that referenced
this pull request
Nov 15, 2020
* Fix detektBaseline task filtering .java files * Remove unused import
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
* Fix detektBaseline task filtering .java files * Remove unused import
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Fix detektBaseline task filtering .java files * Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The util functions
Project.registerDetektTaskandProject.registerCreateBaselineTaskare used to registerdetektanddetektBaselinetasks on the applied Gradle project.Due to (I suppose) legacy reason, the
registerCreateBaselineTaskwas still declaringexcludesandincludeswhile theregisterDetektTaskfunction was updated.This caused the input source for the
detektBaselineto have all the.javafiles filtered out (resulting in issues like #3130) and generally a different inspection from the one performed by the plaindetekttask.Fixes #3130