Fix not being able to override insertFinalNewLine
#3515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3515 +/- ##
=========================================
Coverage 77.61% 77.61%
Complexity 2817 2817
=========================================
Files 462 462
Lines 8720 8720
Branches 1692 1692
=========================================
Hits 6768 6768
Misses 1036 1036
Partials 916 916
Continue to review full report at Codecov.
|
schalkms
approved these changes
Mar 4, 2021
cortinico
approved these changes
Mar 4, 2021
Member
|
Good catch 👏👏👏 |
BraisGabin
approved these changes
Mar 4, 2021
This was referenced Mar 11, 2021
Closed
Closed
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the type in the constant to match
@configurationResolve #3513