SarifOutputReportSpec: Correctly detect Windows root directory on local development machine #3584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f84ece to
e837285
Compare
Codecov Report
@@ Coverage Diff @@
## main #3584 +/- ##
=========================================
Coverage 77.52% 77.53%
- Complexity 2829 2835 +6
=========================================
Files 464 464
Lines 8767 8779 +12
Branches 1713 1720 +7
=========================================
+ Hits 6797 6807 +10
Misses 1046 1046
- Partials 924 926 +2
Continue to review full report at Codecov.
|
chao2zhang
reviewed
Mar 22, 2021
detekt-report-sarif/src/test/kotlin/io/github/detekt/report/sarif/SarifOutputReportSpec.kt
Show resolved
Hide resolved
…al development machine
e837285 to
a265c9e
Compare
chao2zhang
reviewed
Mar 22, 2021
detekt-report-sarif/src/test/kotlin/io/github/detekt/report/sarif/SarifOutputReportSpec.kt
Outdated
Show resolved
Hide resolved
…rif/SarifOutputReportSpec.kt
Contributor
Author
|
Seems Gradle crashed badly, do I have to do something with it? |
Member
|
No worries. This is a known flakiness. I will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while experimenting with Detekt source code I found that test SarifOutputReportSpec is failing on my Windows machine because of C: vs D: Windows root dir detection. So I have created this PR to solve this problem.
Hope it helps and is ok,
Ivos