Decouple Gradle projects #3611
Decouple Gradle projects #3611
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3611 +/- ##
============================================
- Coverage 77.52% 77.50% -0.03%
+ Complexity 2837 2834 -3
============================================
Files 464 464
Lines 8783 8783
Branches 1721 1721
============================================
- Hits 6809 6807 -2
Misses 1047 1047
- Partials 927 929 +2
Continue to review full report at Codecov.
|
BraisGabin
left a comment
There was a problem hiding this comment.
Great boost to the build time 👏🏻👏🏻
| implementation(project(":detekt-report-sarif")) | ||
|
|
||
| testImplementation(project(":detekt-rules")) | ||
| testRuntimeOnly(project(":detekt-rules")) |
There was a problem hiding this comment.
It seems like we have at least one unit test that do far too much. Otherwise we should not need this, right?
There was a problem hiding this comment.
Yeah there are a couple of places detekt-rules is used when it maybe shouldn't be.
I'll open a new issue for that because it would help further with build times when iterating on rules.
This reduces the number of subprojects that have to be recompiled when there's a change to one of the rules, saving quite a bit of time when building the project.
The most interesting change is in the detekt-cli build file since the shadow jar config has changed. The new config can be verified by executing the resulting jar with
--debugand confirming that the bundled rulesets have been registered.