Thanks to visit codestin.com
Credit goes to github.com

Skip to content

jvmTarget can't be null #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BraisGabin merged 1 commit into from
May 22, 2021
Merged

jvmTarget can't be null #3818

BraisGabin merged 1 commit into from
May 22, 2021

Conversation

@BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented May 22, 2021

There is not need to define this property as nullable.

@schalkms
Copy link
Member

schalkms commented May 22, 2021

According to the error message, tests need to be adapted.

D:\a\detekt\detekt\detekt-tooling\src\main\kotlin\io\github\detekt\tooling\dsl\CompilerSpecBuilder.kt: (16, 29): Type of 'jvmTarget' is not a subtype of the overridden property 'public abstract val jvmTarget: String defined in io.github.detekt.tooling.api.spec.CompilerSpec'

@BraisGabin BraisGabin force-pushed the jvm-target-not-null branch from 93c8651 to 7a0d4e1 Compare May 22, 2021 12:32
@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #3818 (7a0d4e1) into main (0c6267f) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3818   +/-   ##
=========================================
  Coverage     83.57%   83.58%           
  Complexity     3059     3059           
=========================================
  Files           456      456           
  Lines          8921     8920    -1     
  Branches       1752     1751    -1     
=========================================
  Hits           7456     7456           
  Misses          542      542           
+ Partials        923      922    -1
Impacted Files Coverage Δ Complexity Δ
...rturbosch/detekt/core/settings/EnvironmentAware.kt 72.22% <0.00%> (+3.80%) 0.00 <0.00> (ø)
...o/github/detekt/tooling/dsl/CompilerSpecBuilder.kt 100.00% <100.00%> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c6267f...7a0d4e1. Read the comment docs.

@cortinico cortinico added this to the 1.18.0 milestone May 22, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 22, 2021
@BraisGabin BraisGabin merged commit 4ec7cc4 into main May 22, 2021
@BraisGabin BraisGabin deleted the jvm-target-not-null branch May 22, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes

@schalkms schalkms schalkms approved these changes

Assignees

No one assigned

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@BraisGabin @schalkms @cortinico