Avoid empty lines when running detekt with type resolution #3909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3909 +/- ##
============================================
+ Coverage 83.53% 83.55% +0.02%
Complexity 3120 3120
============================================
Files 456 456
Lines 8996 9001 +5
Branches 1753 1753
============================================
+ Hits 7515 7521 +6
+ Misses 565 564 -1
Partials 916 916
Continue to review full report at Codecov.
|
schalkms
reviewed
Jun 26, 2021
Member
schalkms
left a comment
There was a problem hiding this comment.
Shall we add a test for this behavior in order to avoid this issue in the future?
Contributor
Author
|
I don't think there is much that can be tested here other than the |
schalkms
approved these changes
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #3684 and solves the issue of empty lines when running detekt with type resolution.