Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Bump Kotlin to v1.5.20" #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schalkms merged 1 commit into from
Jul 7, 2021
Merged

Revert "Bump Kotlin to v1.5.20" #3941

schalkms merged 1 commit into from
Jul 7, 2021

Conversation

@cortinico
Copy link
Member

@cortinico cortinico commented Jul 7, 2021

This PR reverts #3921

See my comment here: #3921 (comment)

Since this is blocking the release process, I'd suggest we:

  1. Revert this PR
  2. Craft a 1.18.0-RC without this PR
  3. Wait for 1.5.21 to release the 1.18.0 stable

@cortinico cortinico added the dependencies Pull requests that update a dependency file label Jul 7, 2021
@cortinico cortinico added this to the 1.18.0 milestone Jul 7, 2021
@cortinico cortinico requested a review from schalkms July 7, 2021 20:28
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #3941 (4cab22d) into main (b2aba98) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 4cab22d differs from pull request most recent head d556ace. Consider uploading reports for the commit d556ace to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3941      +/-   ##
============================================
+ Coverage     83.44%   83.58%   +0.13%     
+ Complexity     3149     3123      -26     
============================================
  Files           456      456              
  Lines          9014     9014              
  Branches       1754     1752       -2     
============================================
+ Hits           7522     7534      +12     
+ Misses          565      564       -1     
+ Partials        927      916      -11
Impacted Files Coverage Δ
...ab/arturbosch/detekt/rules/bugs/MissingWhenCase.kt 88.00% <ø> (ø)
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 90.19% <0.00%> (+1.96%) ⬆️
...t/rules/style/UtilityClassWithPublicConstructor.kt 95.74% <0.00%> (+2.12%) ⬆️
...ekt/generator/collection/DocumentationCollector.kt 87.50% <0.00%> (+2.50%) ⬆️
...rturbosch/detekt/rules/style/UnusedPrivateClass.kt 73.33% <0.00%> (+2.66%) ⬆️
...io/github/detekt/report/sarif/SarifOutputReport.kt 93.93% <0.00%> (+3.03%) ⬆️
...rturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt 78.26% <0.00%> (+4.34%) ⬆️
...arturbosch/detekt/generator/collection/KDocTags.kt 67.50% <0.00%> (+5.00%) ⬆️
...h/detekt/rules/style/DataClassContainsFunctions.kt 100.00% <0.00%> (+5.00%) ⬆️
...sch/detekt/rules/coroutines/SleepInsteadOfDelay.kt 80.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2aba98...d556ace. Read the comment docs.

schalkms
schalkms approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a plan!

@schalkms schalkms merged commit 2a9bbd0 into main Jul 7, 2021
@schalkms schalkms deleted the revert-3921-kotlin-v1.5.20 branch July 7, 2021 21:48
@cortinico cortinico mentioned this pull request Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schalkms schalkms schalkms approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cortinico @schalkms