Enable more rules from naming rule set for detekt code base #3996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marschwar
commented
Aug 1, 2021
Comment on lines
+41
to
43
| val message = "Class name $name is forbidden as it contains: ${forbiddenEntries.joinToString(", ")}" | ||
| report(CodeSmell(issue, Entity.atName(classOrObject), message)) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is a "drive-by" fix as the original code did not successfully remove the trailing comma. The result of the trimEnd should have been re-assigned to message.
Codecov Report
@@ Coverage Diff @@
## main #3996 +/- ##
=========================================
Coverage 83.55% 83.56%
+ Complexity 3179 3175 -4
=========================================
Files 459 459
Lines 9085 9084 -1
Branches 1765 1764 -1
=========================================
Hits 7591 7591
Misses 564 564
+ Partials 930 929 -1
Continue to review full report at Codecov.
|
BraisGabin
reviewed
Aug 3, 2021
detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/config/YamlConfig.kt
Outdated
Show resolved
Hide resolved
cortinico
approved these changes
Aug 3, 2021
BraisGabin
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #3993 and enables checks from the
namingrule set