cache map.get() for size wins #100
Merged
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -18 B (1%) Total Size: 930 B
|
yordis
reviewed
May 27, 2020
| all.get(type).splice(all.get(type).indexOf(handler) >>> 0, 1); | ||
| const handlers = all.get(type); | ||
| if (handlers) { | ||
| handlers.splice(handlers.indexOf(handler) >>> 0, 1); |
There was a problem hiding this comment.
Wouldn't it be better to use Set for the handlers instead?
Owner
Author
There was a problem hiding this comment.
For speed yes, but Set rejects duplicates. EventEmitter, the API contract mitt adheres to, allows duplicate handlers.
There was a problem hiding this comment.
Does that mean I can register the same functions twice? That is really interesting.
Owner
Author
|
Released in 2.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #99 that reduces size a bit by caching the result of
handlers.get()and reusing that value for both the existence check (are any handlers registered) and the index calculation.